Fix #20 - Add unit tests for ResultsAnalyzer

CUTR-at-USF / transit-feed-quality-calculator

A tool that uses the gtfs-realtime-validator to calculate the quality of a large number of GTFS-realtime feeds

Other

7 stars 1 forks source link

Closed Suryakandukoori closed 6 years ago

Suryakandukoori commented 6 years ago

Summary:

Added test cases to test all the graph data from the excel sheet.

Expected behavior:

Tests for default behavior. The test fails in case of an exception.

Please make sure these boxes are checked before submitting your pull request - thanks!

[X] Run the unit tests with mvn test to make sure you didn't break anything
[X] Format the title like "Fix #issue - short description of fix and changes"
[X] Linked all relevant issues
[X] Include screenshot(s) showing how this pull request works and fixes the issue(s)

barbeau commented 6 years ago

Thanks @Suryakandukoori! I think this resolves the remaining issue in https://github.com/CUTR-at-USF/transit-feed-quality-calculator/issues/6#issuecomment-344687116 as well, of using the error title instead of the error description? It's fine with me to have the fix in this PR, just want to document it.

barbeau commented 6 years ago

@Suryakandukoori A heads up that I just added the JUnit info to the pom.xml in https://github.com/CUTR-at-USF/transit-feed-quality-calculator/commit/babde2fbc05e8389898d7cb809e1b169a8edb458, so you don't need to do this any longer. Did you want to make the other changes for this PR or do you want me to go ahead and change and merge?

barbeau commented 6 years ago

I'm closing this in favor of https://github.com/CUTR-at-USF/transit-feed-quality-calculator/pull/26, as I made a few more changes there (I couldn't push to @Suryakandukoori's branch here).