search

CUTR-at-USF / transit-feed-quality-calculator

A tool that uses the gtfs-realtime-validator to calculate the quality of a large number of GTFS-realtime feeds
Other
7 stars 1 forks source link

Unit test failing in testDataSheet() #33

Open barbeau opened 5 years ago

barbeau commented 5 years ago

Summary:

I'm seeing a unit test fail on Travis builds - see: https://travis-ci.org/CUTR-at-USF/transit-feed-quality-calculator/builds/502806533

Here's the error:

trip_id 308241 does not have a schedule_relationship
trip_id 308306 stop_sequence 21 (and potentially more for this trip) does not have a schedule_relationship
trip_id 308306 does not have a schedule_relationship
trip_id 308307 stop_sequence 11 (and potentially more for this trip) does not have a schedule_relationship
trip_id 308307 does not have a schedule_relationship
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.777 sec <<< FAILURE! - in edu.usf.cutr.transitfeedqualitycalculator.test.ResultAnalyzerTest
resultAnalyzerTest()  Time elapsed: 4.768 sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<M[TA Maryland Trip Update]s> but was:<M[etroTransit Vehicle Position]s>
    at edu.usf.cutr.transitfeedqualitycalculator.test.ResultAnalyzerTest.testDataSheet(ResultAnalyzerTest.java:322)
    at edu.usf.cutr.transitfeedqualitycalculator.test.ResultAnalyzerTest.resultAnalyzerTest(ResultAnalyzerTest.java:32)

This failing test is related to the names of the agencies in the output file list, and we didn't change any code in our project.

Maybe a new agency was added to TransitFeeds.com which is causing the name to show up in a different row?

Steps to reproduce:

Run the unit tests on the master branch on Travis

Expected behavior:

Unit tests should pass

Observed behavior:

Above unit test fails

Platform:

Travis