Closed barbeau closed 6 years ago
Reopening - we still need to address the "1-Rules" tab. This should add the entire list of rules that were used in validation, and then add another column that's named "Included in analysis", and the value will be "Yes" for rules that were included, and "No" for fields that were filtered out via the ResultsAnalyzer
constructor via errorsToIgnore
and warningsToIgnore
parameters.
@Suryakandukoori Turns out I wrote the description of this issue incorrectly - in the "Rules" tab and "Error Frequency" tab of the Excel spreadsheet, the ValidationRule.title
should be written to the spreadsheet, not the ValidationRule.errorDescription
. Would you be able to do a quick fix for this? If not I'll tackle it.
@barbeau I will handle this
Summary:
Currently we have two classes in this project,
ErrorDescription
andWarningDescription
, that contain a list of all rules with their descriptions.Instead of hard-coding this here, I'd like to pull it dynamically from the gtfs-realtime-validator library project, so we don't need to update this project each time we add a new rule in gtfs-realtime-validator.
I believe we should be able to use
edu.usf.cutr.gtfsrtvalidator.validation.ValidationRules.getRules()
, which will return a list ofValidationRule
objects. The names of each object should be in the format of "E001", and for eachValidationRule
, you can useValidationRule.getErrorId()
to get the same type of format "E001", andValidationRule.getErrorDescription()
to get the description that's currently defined inErrorDescription
andWarningDescription
.@Suryakandukoori Would you be able to tackle this issue?