CUTR-at-USF / transit-feed-quality-calculator

A tool that uses the gtfs-realtime-validator to calculate the quality of a large number of GTFS-realtime feeds
Other
7 stars 1 forks source link

Histogram of distribution of error and warning types is wrong #7

Closed barbeau closed 6 years ago

barbeau commented 6 years ago

Summary:

After running the tool and looking at the Excel spreadsheet, on the tab "1-Histogram" is a table that shows the distribution of error types. In other words, how many agencies had a feed with 1 error type detected, how many agencies had feeds with 2 error types detected, etc.

However, I'm not seeing any agencies show up in the "1" bin for errors or warnings:

image

image

Looking at the "1-Error Count" tab, there are definitely a number of agencies with 1 type of error detected:

...
Thunder Bay Transit   Vehicle Positions | 2
Big Blue Bus Service Alerts | 1
Big Blue Bus Vehicle Positions | 1
Cincinnati Metro Vehicle Positions | 1
ETS Vehicle Positions | 1
LTD Vehicle Positions | 1
Metro Transit Service Alerts | 1
Metro Transit Vehicle Positions Green   Line | 1
MetroTransit Trip Updates | 1
MetroTransit Vehicle Positions | 1
Nashville MTA Vehicle Positions | 1
OCTA Service Alerts | 1
Saskatoon Transit Vehicle Positions | 1
Thunder Bay Transit Service Alerts | 1

Same for warnings. This looks like a bug when tallying the values in the B column on the "1-Histogram" tab.

Steps to reproduce:

  1. Run the tool
  2. Look at the graphs.xlsx file that's generated in the root folder
  3. Look at the "1-Histogram" tab

Expected behavior:

There should be 13 agencies (using the above sample data I copied from "1-Error Count" tab) that appear in the first entry of the error histogram.

Similar for warnings histogram

Observed behavior:

A value of "0" is shown in the first entry of the error histogram

Platform:

Windows 7 Enterprise with jdk1.8.0_73

@Suryakandukoori Could you please take a look at this?