CUTR-at-USF / usf-mobullity

USF Maps responsive web application
http://maps.usf.edu/
8 stars 7 forks source link

Route polylines don't show when visiting direct link to route layers #401

Open barbeau opened 7 years ago

barbeau commented 7 years ago

Summary:

If you go to: https://maps.usf.edu/#layers/usf_A,usf_B,usf_C,usf_D,usf_E,usf_F

...you should see all USF buses and route polylines on the map.

For some reason, the polylines are currently missing:

image

It should look like:

image

Steps to reproduce:

Go to https://maps.usf.edu/#layers/usf_A,usf_B,usf_C,usf_D,usf_E,usf_F

Expected behavior:

You should see route polylines on the map

Observed behavior:

No route polylines are shown

Workaround - go to https://maps.usf.edu/#layers/ and manually check the layers

Platform:

Windows 7 Enterprise w/ Chrome Version 57.0.2987.133 (64-bit)

jmfield2 commented 7 years ago

Looks like it might be a race condition waiting for the route geometries to load from the server.. It also throws a javascript error at:

https://github.com/CUTR-at-USF/usf-mobullity/blob/603c98211c4ff733164d0f435805bbcc04473f2a/src/client/js/otp/layers/BusPositionsLayer.js#L139

because the vehicles weren't defined - although they do eventually load it seems since those refresh every 5 seconds. But the geometries are only loaded on initialize: and so, somehow they don't seem to load or be assigned to the correct (this) context..

barbeau commented 7 years ago

Thanks @jmfield2!

barbeau commented 7 years ago

From @liquidsunshine, regarding priority of some of these related issues for using the app to show information in the CUTR lobby on a TV display:

Here’s how I would prioritize them, based on CUTR’s needs:

  1. https://github.com/CUTR-at-USF/usf-mobullity/issues/401 (a bug)
  2. https://github.com/CUTR-at-USF/usf-mobullity/issues/403 (allows us to automatically center on CUTR)
  3. https://github.com/CUTR-at-USF/usf-mobullity/issues/404 (allows us to automatically bypass popup)
  4. https://github.com/CUTR-at-USF/usf-mobullity/issues/405 (offers a better view of CUTR)
  5. https://github.com/CUTR-at-USF/usf-mobullity/issues/402 (possibly improves refresh performance)