search

CVMI-Lab / SimGCD

(ICCV 2023) Parametric Classification for Generalized Category Discovery: A Baseline Study
https://arxiv.org/abs/2211.11727
MIT License
85 stars 13 forks source link

About entropy regularization term #3

Closed hjs2027864933 closed 1 year ago

hjs2027864933 commented 1 year ago

Thanks for your excellent work, but I have a doubt about entropy regularization. The code in your repo subtracts the entropy regularization term, but in the paper it adds the entropy regularization term. Is it a tiny clerical error in the paper?

https://github.com/CVMI-Lab/SimGCD/blob/1765452663e7c52e7f0bd0759543655d85524b94/model/simgcd.py#L111-L112

issue

xwen99 commented 1 year ago

Hi @hjs2027864933, thanks for pointing this out. The code is correct, and we will update the paper in the next version.

hjs2027864933 commented 1 year ago

Hi @hjs2027864933, thanks for pointing this out. The code is correct, and we will update the paper in the next version.

thank you for your reply.