search

CVMix / CVMix-src

CVMix source code (including protex documentation) as well as build system and examples / tests
Other
30 stars 30 forks source link

Fixes issue in ekman limiter for KPP #80

Closed vanroekel closed 4 years ago

vanroekel commented 5 years ago

Applies the ekman limiter for stabilizing buoyancy forcing only.

vanroekel commented 5 years ago

reported by Patrick Scholz of AWI. Currently awaiting testing by him. Should not merge until his testing is complete.

vanroekel commented 5 years ago

addresses #79

mnlevy1981 commented 4 years ago

When you get a chance, can you please merge in the latest master? I fixed the issue causing TravisCI to report failures (and also a few one-line bugs, including one in checking whether lEkman has all the data it needs). And are we still waiting for final approval from Patrick Scholz?

vanroekel commented 4 years ago

@mnlevy1981 I have now rebased on to master. I can ping Patrick Scholz to see if he needs to make another check, but I emailed him previously and he said the fix I put in had worked for him. Let me know if you'd like me to get one more approval

mnlevy1981 commented 4 years ago

No need to ping him again, I was just asking because https://github.com/CVMix/CVMix-src/pull/80#issuecomment-509230360 said

Currently awaiting testing by him. Should not merge until his testing is complete.

And I didn't see any follow up. This looks good to me, sorry to take so long to merge it...