search

CVarisco / create-component-app

Tool to generate different types of React components from the terminal. 💻
MIT License
859 stars 58 forks source link

add prettier-eslint hook to lint the components with the rules of the project #7

Closed CVarisco closed 7 years ago

CVarisco commented 7 years ago

It would be great if the new component is already linted with the rules of the project !

thank you @cedmax for the tip!

labithiotis commented 7 years ago

A different way I was going to tackle this was to run prettier over all generated files using rules defined in default config.

I was also thinking there's no need to ask the question to run prettier, just assume if someone has it defined in their default config it would always run it.

cedmax commented 7 years ago

I would use prettier-eslint, I would think eslint is way more common than prettier (I might be wrong tho).

On Sun, 2 Jul 2017, 10:44 Darren Labithiotis, notifications@github.com wrote:

A different way I was going to tackle this was to run prettier https://github.com/prettier/prettier over all generated files using rules defined in default config.

I was also thinking there's no need to ask the question to run prettier, just assume if someone has it defined in their default config it would always run it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CVarisco/create-component-app/issues/7#issuecomment-312481114, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZXac823-f-gBIUiHQYAUfkidZiBrWhks5sJ2Z8gaJpZM4OKTWL .

nealoke commented 7 years ago

@CVarisco +1 for this :) I would just use rules of eslint or if you can. Prettier is mostly hooked in with eslint in my opinion :)

CVarisco commented 7 years ago

Hi guys, now you can create custom templates with this tool! Here the docs: Link

And also, you can share it with the community!!! Here the docs: Link

Thanks a lot for your support 🏆