search

CWRUChielLab / CASAuth

A modified version of the CASAuth plugin found here: http://www.mediawiki.org/wiki/Extension:CASAuthentication
11 stars 5 forks source link

Security: more trimmed/mapped chars in user names #11

Closed leaf-node closed 3 years ago

leaf-node commented 3 years ago

Hi @jpgill86

I have a tweak to the security patch that you merged last week. It blocks additional characters that I found are mapped or stripped from user names. The regexes are based on upstream MediaWiki code.

https://github.com/wikimedia/mediawiki/blob/master/includes/title/MediaWikiTitleCodec.php#L314-L328

I also wrote code to reject user names with invalid Unicode, and to not show a stack trace if MediaWiki itself rejects a user name.

I tested these changes on two wikis. Is this something that you are willing to review and merge?

Thanks, : ) Andrew

jpgill86 commented 3 years ago

Same disclaimer as last time, but it seems OK to me. I will merge. Thanks again!