search

CWorthy-ocean / C-Star

C-Star is a python package for setting up and running ocean model simulations, with a particular focus on marine carbon dioxide removal (mCDR) applications.
https://c-star.readthedocs.io
10 stars 4 forks source link

Notebook that makes ROMS-Tools test data #101

Closed NoraLoose closed 3 weeks ago

NoraLoose commented 1 month ago

Here is a notebook that performs step 1 of #99: it makes ROMS-Tools test data (based on raw input datasets in https://github.com/CWorthy-ocean/roms-tools-test-data), in preparation for an end-to-end testing framework.

This PR is not meant to be merged, I use it purely as a way to share code that later on should go into a pytest framework. We can close this PR either immediately or when further steps of #99 are completed.

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

NoraLoose commented 1 month ago

I tried to make a minimal example (that still makes sense), after discussing the nature of the example with @dafyddstephenson. Despite minimality, making all datasets will take 40 seconds to 1 minute - not optimal, but the bottleneck is https://github.com/CWorthy-ocean/roms-tools/issues/134. I am working to solve the bottleneck on the ROMS-Tools side, so in a few days the data creation should hopefully be much faster.

dafyddstephenson commented 1 month ago

Thanks Nora!

NoraLoose commented 3 weeks ago

I'm closing this because this is part of #108 now.