CWorthy-ocean / C-Star

C-Star is a python package for setting up and running ocean model simulations, with a particular focus on marine carbon dioxide removal (mCDR) applications.
https://c-star.readthedocs.io
10 stars 4 forks source link

Refactor of `exists_locally` (and consequently a lot of other stuff...) #78

Closed dafyddstephenson closed 1 month ago

dafyddstephenson commented 1 month ago

Branched from #74 , do not merge until after merging #74

The initial purpose of this PR was a short refactor of the exists_locally attribute to allow the case when a yaml file describing an input dataset existed locally, but the associated netCDF file did not. It kept unspooling from there with no clear finish line.

Ultimately, this is a lot of spring cleaning that is going to be necessary for the roms-tools integration. Changes to the user experience are fairly minimal (though have been updated in the example notebook), but what's happening behind the scenes is a lot cleaner and more intuitive, with hopefully all bodges and hacks removed.

closes #25

Summary:

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

dafyddstephenson commented 1 month ago

ok some stuff got chewed up in the merges but I think we're good to go now, have updated the diffs here