CWorthy-ocean / C-Star

C-Star is a python package for setting up and running ocean model simulations, with a particular focus on marine carbon dioxide removal (mCDR) applications.
https://c-star.readthedocs.io
10 stars 4 forks source link

`AdditionalCode.base_model` and `InputDataset.base_model` attrs unused #96

Closed dafyddstephenson closed 1 month ago

dafyddstephenson commented 1 month ago

InputDataset, AdditionalCode, and BaseModel are examples of lowest level C-Star classes, and it would be nice for them to not have to be built out of each other.

It is clear from the subclass of InputDataset which model a given dataset belongs to, we shouldn't need a specific attribute.

The existence of the .base_model attribute also prevents the ability of the objects in question to be initialised directly from a subset of the blueprint yaml dictionary (as it is redundant to add a base_model entry in the blueprint under additional_code and input_dataset, and would be impossible to make that entry point to a BaseModel instance anyway).