CWorthy-ocean / roms-tools

Tools for setting up and running ROMS simulations
https://roms-tools.readthedocs.io
GNU General Public License v3.0
7 stars 3 forks source link

Tests are failing due to ModuleNotFoundError #15

Closed NoraLoose closed 1 month ago

NoraLoose commented 1 month ago

see https://github.com/CWorthy-ocean/roms-tools/actions/runs/8972322248/job/24640316780

The error is ModuleNotFoundError: No module named 'scipy'

even though scipy is now part of https://github.com/CWorthy-ocean/roms-tools/blob/main/ci/environment.yml

@TomNicholas any idea what is going wrong?

TomNicholas commented 1 month ago

I have no idea 😕 Does it run locally with an env set up from the same yml file?

NoraLoose commented 1 month ago

Locally, I do

conda env create -f ci/environment.yml
conda activate romstools-test

and then

pytest

which successfully runs the four tests in https://github.com/CWorthy-ocean/roms-tools/blob/main/roms_tools/tests/test_setup.py.

So the ci/environment.yml itself seems to be okay.

NoraLoose commented 1 month ago

Do we maybe have to add scipy to pyproject.toml?

NoraLoose commented 1 month ago

17 fixed the problem.