search

CXIA17 / pe

0 stars 0 forks source link

More accuracy in error message #1

Open CXIA17 opened 5 months ago

CXIA17 commented 5 months ago

Screenshot 2024-04-19 at 4.25.21 PM.png

Over here, the quantity inputted is a whole number, but the error states that quantity must be a whole number.

nus-pe-bot commented 5 months ago

Team's Response

Duplicate of #2031.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inaccuracy for error message in restock

Screenshot 2024-04-19 at 4.56.52 PM.png

In all three inputs, the input is a whole number, but the error message is indicating that whole number is not being inputted.

[original: nus-cs2113-AY2324S2/pe-interim#1806] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is fair, we accept that this is a limitation of our input parsing process for integer values as the error message is inaccurate.

However, the issue is caused by the large input value of "9999999999999.....", which the target users of our application would never enter normally and what our team would consider as extreme user behavior, as defined in the image below.

image.png

Reasonable values entered by the user would not trigger this error message and would work fine, hence, the issue would not occur under expected usage. Our target users are small businesses, so its highly improbable that they would have item stock/quantity that exceeds even a million. Additionally, it is important to note that such inputs does not cause our application to crash, despite it displaying an incorrect error message.

Therefore, the team considers this a valid error message issue but out of scope due it being caused by extreme behavior.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** Did not specify a bound for valid input, please specify a range for valid input either in UG or input prompt of the program.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]