CXIA17 / pe

0 stars 0 forks source link

Error in sequence diagram for XYZCommand #14

Open CXIA17 opened 2 months ago

CXIA17 commented 2 months ago

Should have a red cross below the constructor block since it does not seem like the XYZCommand instance called will be stored.

Screenshot 2024-04-19 at 5.45.01 PM.png

soc-se-bot commented 2 months ago

Team's Response

This is untrue. As per the full sequence diagram:

image.png

We note that the XYZCommand object is created using the constructor, and returned back to the BinBash object. This means that there is a permanent reference to this object throughout this sequence, and thus, it is not deleted from heap memory by the garbage collector at any given time throughout the portrayed sequence.

Furthermore, you'll also wish to note that the returned XYZCommand object is stored in heap memory after the events of this sequence, as the command has to be executed afterwards (and this is after the scope of events portrayed in this sequence diagram).

Hence, it makes no sense to indicate a red cross in this diagram to signify the end-of-life of this XYZCommand object.

Lastly, it seems like this is a result of a misunderstanding of the sequence diagram (as the diagram is accurate), so we will drop the severity of this bug from a Medium to VeryLow.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]