CXIA17 / pe

0 stars 0 forks source link

Error in rounding accuracy #2

Open CXIA17 opened 5 months ago

CXIA17 commented 5 months ago

Screenshot 2024-04-19 at 4.32.11 PM.png

In this scenario, the output sales price have been rounded up, which leads to inaccuracte representation.

Screenshot 2024-04-19 at 4.35.20 PM.png

Same thing also happened for cost price.

soc-pe-bot commented 5 months ago

Team's Response

This is a duplicate of #1522. Once again, this seems like extreme user behavior causing some rounding errors. We do not expect our users to input outrageously large numbers for price as it is not reasonable for our target users (owners of small businesses) to price items at these values. Furthermore, this behavior does not render our application unusable. Refer to #1522 for more details.

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inaccuracy in the update for sales price

The representation is not very accurate.

Screenshot 2024-04-19 at 5.16.25 PM.png


[original: nus-cs2113-AY2324S2/pe-interim#1812] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The input supplied to sale price is a result of extreme user behavior as we do not expect our target users (small business owners) to input outrageously large numbers for sale price. Furthermore, despite this, if for any reason that this number was keyed in accidentally, it doesn't result in our app crashing and users will still be able to update to change it to a proper value. This does not render our app unusable, hence our decision to reject this.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]