search

CXuesong / Serilog.Sinks.Discord

A simple WIP Discord logging sink for Serilog.
Apache License 2.0
1 stars 0 forks source link

Possible to remove reference to Discord.NET? #3

Open th0mk opened 4 years ago

th0mk commented 4 years ago

Because Discord.NET is barely maintained I would like to use a fork like DNetPlus. This causes me to run into issues though, because this library has a reference to Discord.NET. Would it be possible to remove this reference?

CXuesong commented 4 years ago

It is practically possible to simply replace the dependency of this package and publish another version, but technically such action is introducing breaking change. It's impolite to do so 😐

An alternative is to publish a new package depending on the xXBuilderBXx/DNetPlus. It seems that the public API in DNetPlus should be compliant to the original Discord.NET package, right? In that case, simply building my project twice with different dependency should be enough.

Finally, I'm not sure about what's going on with Discord.NET, but if their PRs are much delayed before getting merged or closed, perhaps they could consider giving write permission to some top contributor help with the situation...

I'm just worrying about whether there could be more forks in the coming seasons 🌚

th0mk commented 3 years ago

Just a quick update. It seems like DNet-Labs is currently the main fork. Eventually it is planned to get merged into the main Discord.NET repo, which would make this issue absolute.