CXuesong / WikiClientLibrary

/*🌻*/ Wiki Client Library is an asynchronous MediaWiki API client library targeting modern .NET platforms
https://github.com/CXuesong/WikiClientLibrary/wiki
Apache License 2.0
80 stars 16 forks source link

Support lexicographical data (lexemes) #100

Open mormegil-cz opened 1 year ago

mormegil-cz commented 1 year ago

WikiClientLibrary currently misses BuiltInDataTypes for Wikidata’s lexicographical data.

As far as I can tell, basically three new definitions of the data types, plus a more general implementation of EntityIdFromJson+EntityIdToJson is needed.

See my quick-and-dirty implementation of those (also including a copy-paste of the inaccessible internal sealed DelegatePropertyType from the library) which seems to work fine.

CXuesong commented 1 year ago

Thanks for pointing this out! Regretfully I may not have enough time at the moment 🌚 I'll look into this when I'm available (might be much later).

Just in case you have some time available during the next few months, probably you can propose a PR so that you can at least have something from WCL library without any hacking.

CXuesong commented 1 year ago

Okay I've checked the documentation and realized this is a concept like Item / Property / Entity. Then I guess we'd better wait for a while until I have some more time to look into it.