Revision IDs need to be long everywhere

CXuesong / WikiClientLibrary

/*🌻*/ Wiki Client Library is an asynchronous MediaWiki API client library targeting modern .NET platforms

https://github.com/CXuesong/WikiClientLibrary/wiki

Apache License 2.0

80 stars 16 forks source link

Revision IDs need to be long everywhere #113

Closed mormegil-cz closed 3 months ago

mormegil-cz commented 3 months ago

In df21c73a5636676cff99eeb2a1c7a1e2218f88bf, revision IDs have been changed to 64-bit longs, which is now necessary on Wikidata. However, wrong explicit (int) casts remained in the code at multiple places, causing exceptions.

Fixes #112

CXuesong commented 3 months ago

Thanks for the PR! However, note that master branch has dropped support on .NET Standard 2.1 (#108). If you need support on prior SDK versions, we'll need to also cherry-pick this back to v0.8 branch.

CXuesong commented 3 months ago

Released v0.9.0-int.0.

mormegil-cz commented 3 months ago

If you need support on prior SDK versions, we'll need to also cherry-pick this back to v0.8 branch.

Nope, I’m fine with the current SDK, thanks!