search

CXuesong / WikiClientLibrary

/*🌻*/ Wiki Client Library is an asynchronous MediaWiki API client library targeting modern .NET platforms
https://github.com/CXuesong/WikiClientLibrary/wiki
Apache License 2.0
80 stars 16 forks source link

Backport "Log outs FANDOM with action=logout"-commit to v0.7.x #84

Closed User123698745 closed 3 years ago

User123698745 commented 3 years ago

I tried running the Getting started: Connection, login and logout-example from the wiki using the latest release version 0.7.5. On Fandom wiki sites, I always got an exception on calling LogoutAsync. After digging around in the source code I found out that this bug is already fixed in the latest prerelease version 0.8.0-int.0. So I switched to 0.8.0-int.0, but now after calling RefreshAsync(PageQueryOptions.FetchContent) the Content property of WikiPage is always empty. Now I switched back to 0.7.5 so that the Content property works again, but I can not logout.

Can you please backport the LogoutAsync-fix (043f1999e20d076595a9e7ea842d36a9bb1eb6c1 "Log outs FANDOM with action=logout") to v0.7.x and release it with 0.7.6?

CXuesong commented 3 years ago

So I switched to 0.8.0-int.0, but now after calling RefreshAsync(PageQueryOptions.FetchContent) the Content property of WikiPage is always empty.

This sounds like a bug, so I've fixed it as #85.

I hope you can always check out the latest pre-release ^_^

Also, in the coming days, perhaps you can also fiddle with WikiaSite. Were there to be any FANDOM-specific server-side behavior introduced introduced in the future, this class can guarantee that you can always receive proper client-side compatibility.

CXuesong commented 3 years ago

Released v0.8.0-int.1 and unlisted WikiClientLibrary v0.8.0-int.0 since it's buggy. You can try with the latest one.

User123698745 commented 3 years ago

Both works with v0.8.0-int.1. Thank you very much.

I thought back-porting an existing fix would be easier/quicker, but I am always fine with fixing the actual bug ^^

Thanks for the hint about WikiaSite, I will try it out.