Closed luis261 closed 4 months ago
Could you please don't create requests before pulling your new changes? Because it causes conflict errors.
Sure, I'll take care to avoid such situations in the future. Stay tuned for a revamp/reapplied PR this evening as per https://github.com/CYB3RMX/Qu1cksc0pe/pull/50#issuecomment-2056454764
here's some minor changes to get this started:
except
clauses without a specified exception or an overly general class in the inheritance hierarchy should be avoided, otherwise they'll catch all kinds of unexpected scenarios which they shouldn't really, such as:SyntaxError
(obviously you wouldn't want to catch these since they indicate the code itself is faulty, irrespective of circumstance)KeyboardInterrupt
(you run the risk of suppressing a users intention of shutting down the program if you're in a try codepath with such an overly permissive except when the interrupt is raised)MemoryError
) during an import etc etc, you get the pointsys.exit(1)
calls; I propose direct exception raises instead.=======================================================================
Hey @CYB3RMX,
I appreciate your work on this project. I like what I'm seeing in terms of actual functionality, quite a holistic set of analysis features/file scanning capabilities you've built up here over the years! We use it at my org (as part of a set of lots of other, diverse analysis tooling) and I'd like to personally give back a bit by contributing in my spare time.
Think of the changes in this PR (and the ones I've already submitted, as well as further ones I might sent through the course of tonight) as just a small sample representing the kinds of changes I'd like to apply.
I'm a bit nitpicky when it comes to (Python) code and would also like to take care of typos as well as moving the codebase towards PEP 8 compliance (I'm not a complete stickler when it comes to PEP8 in particular, but let's at least get the simpler things right, such as moving variable and module names from inconsistent naming schemes/
camelCase
towardssnake_case
). However, since you're ultimately in charge here, if you tell me that I should ignore that kinda stuff upfront, I am happy to respect that and will try to let it go ^^I hope you're open to me proposing changes, as I feel like your project could benefit from them (see below). If you are on board with me trying to improve this project, I have a lot more on my mind, e.g.:
Quality:
Usability:
qu1cksc0pe.py
, then continue beyond the main module)Extensions (I work as a Security Analyst at my day job so I might have some stuff to offer when it comes to the analysis-specific parts of the code):
Performance:
I know the plan might seem overly ambitious/big but I'll take it slow in small steps, can't commit to working on this every single weekend but I do have some time I'd like to invest here and I really think I can achieve at least a good portion of the goals listed above given some time over the coming months and a bit of support in terms of reviews from your side.
Looking forward to working with you (: Obviously no need to rush any reviews, nothing of this is particularly urgent and I'll adjust to your pace