search

CYBUTEK / KSPAddonVersionChecker

KSP-AVC in-game plugin.
32 stars 22 forks source link

when the KSP_VERSION is lower than the version of the game, it doesn't check the VERSION at all. #19

Closed linuxgurugamer closed 6 years ago

linuxgurugamer commented 6 years ago

Most likely the cause of issue #9 and #10

This has been bugging me, and I think I've found a real bug:

It seems that when the KSP_VERSION is lower than the version of the game, it doesn't check the VERSION at all.

I'm basing this on the following:

AVC file in folder:

{ "NAME":"K2CommandPodContinued", "URL":"http://ksp-avc.cybutek.net/version.php?id=428", "VERSION": { "MAJOR":1, "MINOR":1, "PATCH":8, "BUILD":1 }, "KSP_VERSION": { "MAJOR":1, "MINOR":3, "PATCH":1 }, "KSP_VERSION_MIN": { "MAJOR":1, "MINOR":2, "PATCH":0 }, "KSP_VERSION_MAX": { "MAJOR":1, "MINOR":3, "PATCH":99 } } AVC downloaded from URL (run through a JSON formatter):

{ "NAME": "K2CommandPodContinued", "URL": "http://ksp-avc.cybutek.net/version.php?id=428", "VERSION": { "MAJOR": 1, "MINOR": 1, "PATCH": 8, "BUILD": 2 }, "KSP_VERSION": { "MAJOR": 1, "MINOR": 3, "PATCH": 0 }, "KSP_VERSION_MIN": { "MAJOR": 1, "MINOR": 2, "PATCH": 0 }, "KSP_VERSION_MAX": { "MAJOR": 1, "MINOR": 3, "PATCH": 99 } } In the output_log.txt:

KSP-AVC -> R:\KSP_1.3.1_dev\GameData\JFJohnny5\K2.version NAME: K2CommandPodContinued URL: http://ksp-avc.cybutek.net/version.php?id=428 DOWNLOAD: NULL GITHUB: NULL VERSION: 1.1.8.1 KSP_VERSION: 1.3 KSP_VERSION_MIN: 1.2 KSP_VERSION_MAX: 1.3.99 CompatibleKspVersion: False CompatibleKspVersionMin: True CompatibleKspVersionMax: True CompatibleGitHubVersion: True

(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 42)

KSP-AVC -> http://ksp-avc.cybutek.net/version.php?id=428 NAME: K2CommandPodContinued URL: http://ksp-avc.cybutek.net/version.php?id=428 DOWNLOAD: NULL GITHUB: NULL VERSION: 1.1.8.2 KSP_VERSION: 1.3 KSP_VERSION_MIN: 1.2 KSP_VERSION_MAX: 1.3.99 CompatibleKspVersion: False CompatibleKspVersionMin: True CompatibleKspVersionMax: True CompatibleGitHubVersion: True UpdateAvailable: False You can clearly see that in the log, it specifically says that no update is available, AND in-game, it shows the mod in green

when I changed the website to reflect the correct version of the game. It's obviously using the data from the website, and, IMHO, is also obviously now totally useless to verify that mods are ok after the game has updated.

The specific circumstance I ran into was when checking parts mods, which have a very relaxed MIN and MAX values; but if the base KSP_VERSION is not matching the current game, it doesn't raise a flag at all.

linuxgurugamer commented 6 years ago

This issue was moved to linuxgurugamer/KSPAddonVersionChecker#9