search

CYBUTEK / KerbalEngineer

Kerbal Engineer v1.0 (current in-development build).
227 stars 101 forks source link

Improve and add additional help string definitions #110

Closed rkagerer closed 8 years ago

rkagerer commented 8 years ago

See http://forum.kerbalspaceprogram.com/index.php?/topic/17833-111-kerbal-engineer-redux-1110-2016-04-29/&do=findComment&comment=2809646

Some time ago I made several refinements and additions to my local copy of HelpStrings.xml. I'm not sure how well this has been tested and would be grateful if cybutek or Padishar could skim through before accepting the request.

Gerry1135 commented 8 years ago

I've not checked it all for typos etc. but it looks ok to me in general.

harryyoung commented 8 years ago

Sorry to bust this but the help strings are actually in source (the specific Readouts at https://github.com/CYBUTEK/KerbalEngineer/tree/master/KerbalEngineer/Flight/Readouts) and compiled on flight scene load from the dll if kerbal engineer can not find the xml. Most of the changes you made have been implemented into the source in similar form already (i did a while back). If they don't appear for you just delete the file.

I suggest you crosscheck with the source readouts to see if anything can be filled in or improved there and then remove the file from the output to avoid futher confusion..

rkagerer commented 8 years ago

Cool! If / when I get a chance I'll cross reference the changes I did with the original source code and make a new pull request. Since they're sprinkled across a few files this will take more time and I may not get to it for a while.