search

CYBUTEK / KerbalEngineer

Kerbal Engineer v1.0 (current in-development build).
227 stars 101 forks source link

1.4.x support #147

Open ianglennon opened 6 years ago

ianglennon commented 6 years ago

Hi,

Great mod, really missing it now that KSP has upgraded to 1.4. Any news on an updated release?

Jacalz commented 6 years ago

I would really want this too and also better support for making history expansion! 🙂

cculianu commented 6 years ago

Please please please add 1.4.1 support when you have time! This is my favorite mod!

lnxbil commented 6 years ago

Besides the warning on game entry, it seems to work just fine. Have you experienced any problems?

cculianu commented 6 years ago

Oh hey... you're right. It works perfectly. Well.. color me surprised.

Awesome!

jrbudda commented 6 years ago

https://github.com/jrbudda/KerbalEngineer/releases/tag/1.1.4.0

Jacalz commented 6 years ago

Aha, it looks like you have taken over the development in your own fork? @jrbudda

jrbudda commented 6 years ago

I don't really want to 'take over' but thought I'd spend a couple hours getting something out there working for folks. I did submit a PR for the changes, but it looks like PRs havent been pulled here since October so I uploaded a release on my fork.

Jacalz commented 6 years ago

That is great and I wouldn’t say that taking over would be a bad thing since this repo is already pretty much dead but yeah 🙂 Great work though 👍

cculianu commented 6 years ago

@jrbudda DUDE!! I love you! Thank you for this!! YOU ARE THE BEST!!

If he doesn't respond in some time -- think about maybe submitting this to CKAN so that others may benefit?

Thanks again!!

oneam commented 6 years ago

Thanks @jrbudda Unfortunately, I found an issue with your update, if I attach RCS thrusters to an engine plate it throws:

[Exception 20:52:54.0799760]: SimManager.StartSimulation() // Object reference not set to an instance of an object []: at KerbalEngineer.VesselSimulator.PartSim.DecoupledInStage (.Part thePart) [0x00000] in :0 at KerbalEngineer.VesselSimulator.PartSim.New (.Part p, Int32 id, Double atmosphere, KerbalEngineer.LogMsg log) [0x00000] in :0 at KerbalEngineer.VesselSimulator.Simulation.PrepareSimulation (KerbalEngineer.LogMsg _log, System.Collections.Generic.List`1 parts, Double theGravity, Double theAtmosphere, Double theMach, Boolean dumpTree, Boolean vectoredThrust, Boolean fullThrust) [0x00000] in :0 at KerbalEngineer.VesselSimulator.SimManager.StartSimulation () [0x00000] in :0

jrbudda commented 6 years ago

Ah yea looks like anything surface-attach

jrbudda commented 6 years ago

should be fixed here https://github.com/jrbudda/KerbalEngineer/releases

You'd think FindAttachNodeByPart would never return null for a part that is actually attached and AttachNode's can be of type SURFACE. But you'd be wrong.

cculianu commented 6 years ago

Dude, you are awesome. Thanks for the quick turn-around on this.

As a fellow programmer, I can relate. Obvious API calls not doing the obvious. ;)

Ha ha -- good work though man. Thanks!!