search

CYBUTEK / KerbalEngineer

Kerbal Engineer v1.0 (current in-development build).
227 stars 101 forks source link

Files for configuration that are written to disk on every session should be stored in the "PluginData" directoy. #98

Closed Galenmacil closed 8 years ago

Galenmacil commented 8 years ago

This is to avoid Module Manager rebuilding patches from scratch on every game loading instead of relying on it's the much faster cache. Please, read this for more detail:

https://github.com/m4v/RCSBuildAid/issues/32

CYBUTEK commented 8 years ago

KER saves its configuration data using its own XML serialisation. As far as I am aware Module Manager only builds patches from .cfg files that use the ConfigNode system. Could you please elaborate on the issue as it stands with this particular mod?

Gerry1135 commented 8 years ago

I think he means that MM rebuilds its cache when any file that isn't in a PluginData folder is modified. The settings should be moved into PluginData rather the Settings folder.

CYBUTEK commented 8 years ago

As expected, MM isn't indiscriminate in the files that it checks. It only checks the ones that are loaded and stored within the GameDatabase as configuration files for cache breaking changes.

https://github.com/sarbian/ModuleManager/blob/master/moduleManager.cs#L1001

Gerry1135 commented 8 years ago

I did think it sounded a bit strange and I certainly haven't noticed it ignoring the cache (though I don't tend to run with a lot of MM patches unless I'm doing something RO/RSS related. I presume you're pretty certain that none of the KER files get included though it wouldn't be hard to build a version of MM that dumps out the name of every file it checks just to be sure.

Kerbas-ad-astra commented 8 years ago

Module Manager already logs which files cause it to rebuild the cache (broken out by additions, changes, and deletions). It wouldn't be bad to verify this experimentally, but I don't believe I've ever seen KER's (or any) XML files in the list.

Galenmacil commented 8 years ago

I think this issue is/was always resolved. It is clear that Module Manager ignore all files not ending in .CFG and those present in "plugindata". I believe this issue can be closed.

CYBUTEK commented 8 years ago

Thanks for the poke on closing this issue @Galenmacil.