CYGNUS-RD / reconstruction

Camera and scope analysis tools
0 stars 25 forks source link

fixed the reading of the environmental variables #236

Closed antorita closed 9 months ago

antorita commented 9 months ago

I added a new file: env_variables.txt to link the name of the sensor and the envariables variables.

GioDho commented 9 months ago

Ciao! In general it looks fine to me. On how many runs have you tested this new version? Have you checked that the environmental variables are read identically as before in runs where it was already working? Is the output ok (no repetition of numbers and so on)?

I think that in utilities.py, in each except you should initialise the value of the dslow[i][j]. In the end the easiest thing would be to put them at -99 which is a value that makes no sense from a physical point of view. This way, that is a number but easily recognizable as "the sensor did not read the data".

Also, I would move env_variables.txt into the modules_config folder

antorita commented 9 months ago

In reconstruction.py I removed try and except in the reconstruction of the environmental variables.

When there are not the environmental variables the value is set at -99.

I tested this version with the runs: 17450, 25000, 25516, 35000, 35100, 37597, 37604, 43000 and the output is the same as before.