search

CYPIAPT-LNDSE / sdm-app

Helping young people and their parents or guardians make informed decisions about their treatment or care
https://cypiapt-lndse.github.io/sdm-app/
2 stars 0 forks source link

Add .png illustrations to illustrations directory #12

Closed njsfield closed 7 years ago

njsfield commented 7 years ago

Related #9

bradreeder commented 7 years ago

@njsfield Looking good. @des-des should correct me on this if I'm mistaken, but I'd aim to link all your commits to the issue they're related to in the commit message:

git commit -m 'commit description' -m 'related #issueNumber'

That way when you go into your issue every commit you've made against it will be linked to it in the chat history.

njsfield commented 7 years ago

Apologies- will do! :)

bradreeder commented 7 years ago

These are all looking ❤️ . That's a tonne of work for one day ^_^;

Thanks for referencing the issues but remember to give your commits descriptions as well like you were doing before. Something like:

git commit -m 'add png of second scene' -m 'related #9'

The text following the first '-m' add png of second scene will appear as the commit title and the text following the second '-m' related #9 will appear as the commit message in that example. Only saying in case my prior message came across as asking you to not describe the commit in favour of only referencing the issue.

njsfield commented 7 years ago

Ah no problem! I must of been using the command wrong (without the second '-m') as I did add the 'add' messages but hadn't checked here, will do :)

jbesraa commented 7 years ago

looks amazing!

des-des commented 7 years ago

@njsfield assuming you meant to assign me! If you want me to review + merge, pls assign!

njsfield commented 7 years ago

Apologies! Will do going forward