Closed jbesraa closed 7 years ago
im working on the colors #16
@esraajb Looking at this as an outsider, I'm unsure what problem 1 refers to. If you go under the list of your issues you should see under the issue name a '#' followed by a number. Every time you make a PR link to the issue you're working on in the description using the '#issueNumber' format and it will automatically link your pull request to that issue.
cool. changed.
thanks (:
No worries, thanks @esraajb . Also bare in mind the comment I made on another pull here: https://github.com/CYPIAPT-LNDSE/sdm-app/pull/12#issuecomment-276417635
It might seem a little pedantic, but it means over time that the issues will contain a complete history of all the work you've done on it which helps everyone in a project track progress. 😸
@esraajb Let us know when you'd like us to review (change label to Awaiting Review)
last commit:
@esraajb I am assigned to review but there are new commits being pushed up. reassign me when work is done on branch.
Also, add issue numbers to commit messages (in future)
sure. sorry.
No problem!
fixed merge conflicts
problems:
16 need to change the color of the home icon, main title (SDMAPP) and the menu icon.
17 start button is not responsive.