CYPIAPT-LNDSE / sdm-app

Helping young people and their parents or guardians make informed decisions about their treatment or care

https://cypiapt-lndse.github.io/sdm-app/

2 stars 0 forks source link

Homepage #15

Closed jbesraa closed 7 years ago

jbesraa commented 7 years ago

problems:

16 need to change the color of the home icon, main title (SDMAPP) and the menu icon.

17 start button is not responsive.

jbesraa commented 7 years ago

im working on the colors #16

bradreeder commented 7 years ago

@esraajb Looking at this as an outsider, I'm unsure what problem 1 refers to. If you go under the list of your issues you should see under the issue name a '#' followed by a number. Every time you make a PR link to the issue you're working on in the description using the '#issueNumber' format and it will automatically link your pull request to that issue.

jbesraa commented 7 years ago

cool. changed.

thanks (:

bradreeder commented 7 years ago

No worries, thanks @esraajb . Also bare in mind the comment I made on another pull here: https://github.com/CYPIAPT-LNDSE/sdm-app/pull/12#issuecomment-276417635

It might seem a little pedantic, but it means over time that the issues will contain a complete history of all the work you've done on it which helps everyone in a project track progress. 😸

njsfield commented 7 years ago

@esraajb Let us know when you'd like us to review (change label to Awaiting Review)

jbesraa commented 7 years ago

last commit:

changed classes name
added Depression page
added questions to the sidebar

des-des commented 7 years ago

@esraajb I am assigned to review but there are new commits being pushed up. reassign me when work is done on branch.

Also, add issue numbers to commit messages (in future)

jbesraa commented 7 years ago

sure. sorry.

des-des commented 7 years ago

No problem!

jbesraa commented 7 years ago

fixed merge conflicts