CYPIAPT-LNDSE / sdm-app

Helping young people and their parents or guardians make informed decisions about their treatment or care
https://cypiapt-lndse.github.io/sdm-app/
2 stars 0 forks source link

Templating for cards #18

Closed denesnori closed 7 years ago

denesnori commented 7 years ago
des-des commented 7 years ago

Happy to merge this. Assign me when happy @skibinska

denesnori commented 7 years ago

@des-des The last message is for me or for Ewelina (@skibinska)?

des-des commented 7 years ago

@denesnori ops yeah whenever you are ready

des-des commented 7 years ago

@denesnori we still have a bug: image

If think you can solve this with js.. You have four tools.

  1. JS can access url
  2. JS can hold state (ie increment the counter)
  3. can change the url
  4. can access dom

I really think this this is a bad way, if you are too tight on time I can let this go as this is prototype.. Just fix the bug and have another think, then re-assign

denesnori commented 7 years ago

Ok, I'll work on this.

des-des commented 7 years ago

@denesnori if you want to skype i can lend a hand

bradreeder commented 7 years ago

@denesnori I raised this with @njsfield and @esraajb in separate prs but remember when you commit to add to the commit message a reference to the issue it relates to. See a copy of this post for rationale:

screen shot 2017-02-01 at 12 35 08
denesnori commented 7 years ago

Ok @bradreeder , I will bear it in mind when I next push to github.

denesnori commented 7 years ago

I've just seen you comment @des-des. Thanks for offering help :). I made a new version and handle the nextQuestion links in a slightly different way, but I think it is still dodgy. If you think it worth it, we can skype about it. :)

des-des commented 7 years ago

@denesnori am happy!