CYPIAPT-LNDSE / sdm-app

Helping young people and their parents or guardians make informed decisions about their treatment or care

https://cypiapt-lndse.github.io/sdm-app/

2 stars 0 forks source link

Feel blue #29

Closed denesnori closed 7 years ago

denesnori commented 7 years ago

Unify styling.

des-des commented 7 years ago

@denesnori commit messages missing commit numbers !!!!!!

des-des commented 7 years ago

No issue number in pull desc!!

des-des commented 7 years ago

13

denesnori commented 7 years ago

ups, I 've seen your other comment. I referencd issue 21 and 22 in some of the commit....but not in all...beacuse I though that it would indicate this pull requests belong to thos issues, but I felt pointless to reference all 10-20 pushes on this branch. Should I reference the issues every single time?

des-des commented 7 years ago

@denesnori Yes, each commit sound have an issue

des-des commented 7 years ago

@denesnori are you sure your fixes work? Have you tested them? 6 === '6' is false..?

denesnori commented 7 years ago

Working from new branch with CSS changes

des-des commented 7 years ago

@denesnori The idea is not to merge code into master with obvs bugs.. As I review each pull in isolation,

des-des commented 7 years ago

:( sorry!

des-des commented 7 years ago

was about to say am happy to merge a long as you understand!