requirements.txt - use correct beautifulsoup4 package name

CZ-NIC / convey

CSV processing and web related data types mutual conversion

GNU General Public License v3.0

18 stars 4 forks source link

requirements.txt - use correct beautifulsoup4 package name #37

Closed nicki-krizek closed 4 years ago

nicki-krizek commented 4 years ago

The package "bs4" is only a placeholder for the actual package "beautifulsoup4" https://pypi.org/project/bs4/

This fixes a pkg_resources import issue when installing convey without pip.

NOTE: I didn't test the pip installation with this change

e3rd commented 4 years ago

Tested and worked, thanks! I would never say there might be such a problem here.

nicki-krizek commented 4 years ago

Thanks! It's probably related to the way pkg_resources works, but I don't have experience with it and I didn't dive to deep into the issue once I found out how to fix it :)

e3rd commented 4 years ago

Can I asked how did you install without pip? I tried with venv and worked great even with bs4 shortcut. (But I admit it's better now.)

python3 -m venv venv
.  venv/bin/activate
cd pool/
pip3 install .

Ubuntu 19.04

nicki-krizek commented 4 years ago

I use Arch and I prefer to use the distro package manager instead of pip, so I created a PKGBUILD that depends on the distribution's python packages.

One of them is python-beautifulsoup4, and although it installs the python package files to /usr/lib/python3.8/site-packages/bs4/, the egg info is in /usr/lib/python3.8/site-packages/beautifulsoup4-4.8.1-py3.8.egg-info/, which might be the cause.

e3rd commented 4 years ago

And what if we publish a new version? Can I do something the PKGBUILD can be automatically upgraded or you have to do it manually?

nicki-krizek commented 4 years ago

You don't have to worry about it, it's the AUR package mainainer's responsibility (ArchiWiki#AUR) . You could flag it out-of-date to let me the maintainer know there's a new version.

If you'd like, I can add you as a co-maintainer, but unless you're an Arch user actively using that PKGBUILD from AUR, it's just an extra burden you don't need to carry :)