Reorganize XML-related functions - Githubissues

CZ-NIC / django-eidas-specific-node

GNU General Public License v3.0

2 stars 2 forks source link

Reorganize XML-related functions #46

Closed jiri-janousek closed 5 years ago

jiri-janousek commented 5 years ago

There are enough XML-related functions to deserve own submodule eidas_node.xml:

eidas_node.utils contains 5 XML-related functions.
eidas_node.saml contains decrypt_xml
A new function remove_extra_xml_whitespace should be extracted from the code in decrypt_xml
More functions are expected: sign_xml (#10, #27), verify_xml_signature (#9), encrypt_xml (#45)

In addition, IdentityProviderResponseView.get_saml_response should not call decrypt_xml directly but via SAMLResponse.decrypt.