search

CZ-NIC / django-eidas-specific-node

GNU General Public License v3.0
2 stars 2 forks source link

Invalid signature while assertions are both signed and encrypted #89

Closed samikarvonen closed 4 years ago

samikarvonen commented 4 years ago

This might be related to issue https://github.com/CZ-NIC/django-eidas-specific-node/issues/87.

I updated our specific connector to version 0.6.0 and got it working with assertion encryption disabled. However, when I enable the encryption I get an error from our sp which says the signature of the assertion is not valid. I fixed this issue in our development version by temporarily disabling assertion signing and leaving the encryption on. So I can either have the assertions signed or encrypted but when I enable both the signature of the assertions seems to be invalid.

jiri-janousek commented 4 years ago

We should fix #87 first and then check whether signature verification succeeds. Does the error message of your SP contain any information about why the signature is considered invalid?

samikarvonen commented 4 years ago

No I didn't get anything else than "signature is not valid". We could try debugging more if #87 doesn't fix the problem.

jtalir commented 4 years ago

Looks like #87 fixed problem with our SP. But our SP apparently doesn't require signed assertions as well and so there is no guarantee that it validates signatures on assertions if they exists

samikarvonen commented 4 years ago

87 Fixed our problem too.

tpazderka commented 4 years ago

Closing as #87 is merged.