CZ-NIC / django-fido

Django application for FIDO protocol U2F
GNU General Public License v3.0
28 stars 11 forks source link

Fix deprecation warnings and drop support for Django 1.11 #135

Closed mscansian closed 2 years ago

mscansian commented 2 years ago

Dropping support for Django 1.11

The changes made to django.conf.urls are not compatible with Django 1.11. With the release of Django 4.0 (which will happen any time soon), django.conf.urls will be removed leaving users with a broken dependency (in case we don't fix it).

tpazderka commented 2 years ago

Thanks for your contribution!

I am fine with dropping 1.11.

@stinovlas what are your thoughts?

stinovlas commented 2 years ago

isort in quality check is failing. Other than that, I agree. LGTM

mscansian commented 2 years ago

isort in quality check is failing. Other than that, I agree. LGTM

Fixed

@stinovlas @tpazderka

stinovlas commented 2 years ago

@tpazderka LGTM. If you're OK with this as well, please merge the PR.

@mscansian Thanks for the contribution :-)!

tpazderka commented 2 years ago

Rebased and merged.

@mscansian Thanks for the contrbuition!

mscansian commented 2 years ago

@tpazderka Hey, is it possible to release the changes to PyPI?

tpazderka commented 2 years ago

We need to deal with #146 first as the master branch is currently broken for existing users.