CZ-NIC / pyoidc

A complete OpenID Connect implementation in Python
Other
711 stars 258 forks source link

fix for some provider return birthdate:null in userInfo #831

Closed pkking closed 1 year ago

pkking commented 1 year ago

Signed-off-by: Li Chaoran pkwarcraft@gmail.com

pkking commented 1 year ago

@schlenk seems the code check failed has nothing to do with this PR?

schlenk commented 1 year ago

yes, that is some mypy changes fallout. I'll take a look later today.

schlenk commented 1 year ago

I change the fix a bit. Your fix was fine, but would cause an exception when used in a client to fetch userinfo, as the verify() returned false due to the empty values. Now the code filters out empty or null values from responses.

codecov-commenter commented 1 year ago

Codecov Report

Merging #831 (c8cab2f) into master (f4a483d) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
- Coverage   63.80%   63.80%   -0.01%     
==========================================
  Files          64       64              
  Lines       11877    11882       +5     
  Branches     2158     2159       +1     
==========================================
+ Hits         7578     7581       +3     
- Misses       3695     3696       +1     
- Partials      604      605       +1     
Impacted Files Coverage Δ
src/oic/oic/message.py 69.82% <100.00%> (-0.09%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.