search

CZDanol / StreamDeck-DiscordVolumeMixer2

Discord Volume Mixer plugin for StreamDeck
GNU General Public License v3.0
41 stars 2 forks source link

Pressing the dials does not mute or unmute the user #22

Closed AlexanderLeporiday closed 1 month ago

AlexanderLeporiday commented 2 months ago

Action is configured correctly but pressing the dial does not perform the same action as tapping the touch screen. Tapping the screen works as expected. image

Expected Action: User becomes muted/unmuted.

Actual Result: Nothing happens!

Phyore commented 2 months ago

Also having this issue. If anything: "however when tapping the screen to mute someone it doesn't always mute / unmute the person I tried to mute/unmute. Also the tap on the wheel to mute does not work"

FynnleyNeko commented 1 month ago

This is caused by this plugin being unupdated too long, it uses the dialPress action which has been removed in StreamDeck 6.5 and deprecated since 6.1, the correct way to capture the dial press is now dialDown (and dialUp). This is an easy self edit in the JS for everyone that quickly needs to fix it themsevles

CZDanol commented 1 month ago

The plugin is written in C++, I guess I'll need to dig into it sometime...

FynnleyNeko commented 1 month ago

Ah shit, just stumbled across this while looking around plugins and didnt read the code yet to edit it myself. its a quick swap of instances of dialPress for dialDown. Streamdecks SDK split dialPress into dialDown and dialUp so you could technically measure the length for actions, but dialDown kinda works like dialPress.

Depending on how quick you are I may just clone, do the edits and submit a pull. Was gonna fix this for myself anyways, really love your plugin over the default discord integration

CZDanol commented 1 month ago

If you'd do it, that would be awesome :) I got to the state where I don't have energy to do hobby programming now, because I do enough of it in work.

FynnleyNeko commented 1 month ago

Just wondering, your current minimum software support is StreamDeck 5.0 according to manifest, if I do these changes that will change to 6.1, thats a huge jump, is that fine seeing as we are on 6.10 as latest now?

CZDanol commented 1 month ago

No problem at all

FynnleyNeko commented 1 month ago

Can I ask what environment you had when compiling this? The changes were quick and not that many, but spent more than an hour now with MSVS giving me so many errors about stuff I didnt touch. Installed Qt6 6.2.1 MSVC 2019 x64 as in the readme (and added websockets so all dependencies are met)

CZDanol commented 1 month ago

Hmm, should match the readme. And the PC with the env is a few days away from me right now. Perhaps just try the newest Qt?

FynnleyNeko commented 1 month ago

Turned out was something with the CMakeLists.txt not linking the deps folder quite right for my version of MSVS. So off to testing now, may need a bit to gather some users in VC and try, but got an error free release build with latest MSVS and QT 6.7.1

If it works will create a pull here and on qtstreamdeck2 in an hour or so :)

CZDanol commented 1 month ago

Great, thanks :) I'll handle the release process afterwards. But probably after monday, as I said, currently not at the PC with the certificate and such

FynnleyNeko commented 1 month ago

Tested working, I submitted the pulls here:

https://github.com/CZDanol/StreamDeck-DiscordVolumeMixer2/pull/24 https://github.com/CZDanol/QtStreamDeck2/pull/1

CZDanol commented 1 month ago

Fixed in v2.0.1.9: https://github.com/CZDanol/StreamDeck-DiscordVolumeMixer2/releases/tag/v2.0.1.9