search

CZEMacLeod / MSBuild.SDK.SystemWeb

This MSBuild SDK is designed to allow for the easy creation and use of SDK (shortform) projects targeting ASP.NET 4.x using System.Web.
MIT License
151 stars 8 forks source link

Add handling for ManagePackageVersionsCentrally #30

Closed christianbumann closed 2 years ago

christianbumann commented 2 years ago

It would be nice if your scripts are working with this https://github.com/NuGet/Home/wiki/Centrally-managing-NuGet-package-versions

Maybe a condition on the property group (setting ManagePackageVersionsCentrally) here https://github.com/CZEMacLeod/MSBuild.SDK.SystemWeb/blob/main/src/MSBuild.SDK.SystemWeb/Sdk/MSBuild.SDK.SystemWeb.DefaultPackages.props

Maybe an additional check on line 12 https://github.com/CZEMacLeod/MSBuild.SDK.SystemWeb/blob/main/src/MSBuild.SDK.SystemWeb/Sdk/MSBuild.SDK.SystemWeb.DefaultPackages.targets is also required for setting ManagePackageVersionsCentrally....

christianbumann commented 2 years ago

I don't need this change, as I can set in addition to ManagePackageVersionsCentrally the setting UsingMicrosoftCentralPackageVersionsSdk to true