CaNS-World / CaNS

A code for fast, massively-parallel direct numerical simulations (DNS) of canonical flows
MIT License
197 stars 69 forks source link

Implicit `firstprivate` generated when compiling with OpenACC #70

Closed p-costa closed 1 year ago

p-costa commented 1 year ago

Since 23.3 (?) nvfortran writes Generating implicit firstprivate(...). Though this is not a problem, to be consistent with our "implicit is better than implicit" philosophy. It would be good to explicitly declare these with firstprivate attribute (even though the standard mentions that this is OpenACC's default for scalar values).

p-costa commented 1 year ago

Lets let nvfortran generate these prompts for now, as we are doing things as expected from the OpenACC standard.