search

CaRdiffR / nounprojectR

R package to use the noun project api
Other
12 stars 10 forks source link

Implementing authorisation in R; dividing functions & writing tests... #6

Closed brennanpincardiff closed 5 years ago

brennanpincardiff commented 5 years ago

Hi Dave, I've done a few hours work tonight to implement the authorisation solution. In order to help this I have also done some divided the functions into three groups. I have written some tests too. It passes testing but doesn't pass devtools::check() yet. If you have a little while, maybe have a quick look and accept the pull request. It creates a new branch anyway. I don't want to be approving my own changes. How does that sound? Best wishes, Paul

DaveParr commented 5 years ago

Sure, looking at it now @brennanpincardiff This will actually go into the master branch of the project as you've PR from your branch in your repo to the master branch in this one, but that's not a big deal right now :)

Thanks for your helpd @cderv