CaRdiffR / nounprojectR

R package to use the noun project api
Other
12 stars 10 forks source link

Refactor files and document with dependencies #7

Closed DaveParr closed 5 years ago

DaveParr commented 5 years ago
DaveParr commented 5 years ago

I think the 'form' we should take is: Each developer, on their fork of the repo, can kind of do whatever. I suggest

The developer then has their 'working' code in their master branch. To check it's compatibility they had the organisation repo caRdiffR/nounprojectR:master set as a remote called upstream like this example. they then 'sync with an upstream remote'

Doing it this way means they have already dealt with keeping themselves up to date with other changes, making the PR easier to merge for us. The links are the GitHub issued docs which I think encourage this usage.

An alternative is possible:

(I know right now it's basically just us in both roles, but I still think this is good practice for us to do the full job when wearing the relevant hat :))