search

CaTzil / service.subtitles.napisy24pl

Napisy24.pl is Addon for searching and downloading subtitles from KODI
GNU General Public License v2.0
8 stars 9 forks source link

Addon doesnt work (?) since Kodi 19 #27

Closed Dinth closed 3 years ago

Dinth commented 3 years ago

Hi. I was happy to see this addon be one of the first subtitle addon upgraded to Kodi 19/Python 3 a while ago. Unfortunately, i have never managed to get Python3 version to work since then. Logging in works fine, same with search, but when i try to download any subtitle im getting an error. Looking at kodi.log: CUtil::SplitParams("C:\XXX\Kodi\iserdata\addon_data\service.subtitles.napisy24pl\temp\subs.zip", C:\XXX\Kodi\userdata\addon_data\service.subtitles.napisy24pl\temp") - end of string while searching for ) or "

CaTzil commented 3 years ago

Hi @Dinth Thank you for reporting an issue, 🙏🏼 Yesterday, I've tried to fix it, seems that it related to unzipping the archive. I didn't able to find a working method to extract the subs from zip files

pogo1975 commented 3 years ago

hi @CaTzil i worked around this problem find the attached changed files, i think it is required to include urllib i addon.xml but i do not know this for certain,

Think that required changes are only in NapisyUtils.py but this is my firs ever "hack" of python script, so it needs checking, code is borrowed from another plugin "subscene"

Regards Jarek changes.zip

CaTzil commented 3 years ago

Does it work for you?

Can you check if downloading subs of 2 separate video files? I've used something similar and it works only for the first time, downloading subs to a second file throws an error

On Sun, Feb 28, 2021 at 4:32 PM pogo1975 notifications@github.com wrote:

hi @CaTzil https://github.com/CaTzil i worked around this problem find the attached changed files, i think it is required to include urllib i addon.xml but i do not know this for certain,

Think that required changes are only in NapisyUtils.py but this is my firs ever "hack" of python script, so it needs checking, code is borrowed from another plugin "subscene"

Regards Jarek changes.zip https://github.com/CaTzil/service.subtitles.napisy24pl/files/6056935/changes.zip

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CaTzil/service.subtitles.napisy24pl/issues/27#issuecomment-787461849, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4WVFT5QTNHJUTAPMOLOGDTBJHXVANCNFSM4X7JU5KA .

pogo1975 commented 3 years ago

as much as i can check it is working, downloaded couple of subtitles for diffrent tv shows without error

CaTzil commented 3 years ago

Thanks, I'll check it out asap

On Sun, Feb 28, 2021, 17:21 pogo1975 notifications@github.com wrote:

as much as i can check it is working, downloaded couple of subtitles for diffrent tv shows without error

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CaTzil/service.subtitles.napisy24pl/issues/27#issuecomment-787468985, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4WVFXU7IWNRHNVUMC4663TBJNQFANCNFSM4X7JU5KA .

CaTzil commented 3 years ago

I've tested your code, it throws 

Create - unsupported protocol(archive) in archive://

image

I've tried similar solution (which i've copied from one of the addons) with zip protocol, and it works, but only once.

Maybe, there is some issue with my setup, I will try to setup a regular dev env, if it solves the basic usage I will upload a fix.

CaTzil commented 3 years ago

Fixed in v3.0.2

https://github.com/xbmc/repo-scripts/pull/1894