Again me - Githubissues

CaTzil / service.subtitles.napisy24pl

Napisy24.pl is Addon for searching and downloading subtitles from KODI

GNU General Public License v2.0

8 stars 10 forks source link

Again me #3

Closed struart closed 10 years ago

struart commented 10 years ago

Hello its me again (last time i promise :D )

You didnt understand me last time when i wrote about BeautifulSoup4. So again :D In order to make this addon to work you CANNOT use BeautifulSoup4. So to make this work do this: Edit addon.xml: change import script.module.beautifulsoup4 4.3.2 to script.module.beautifulsoup 3.2.1

Edit service.py: change "import bs4" to "from BeautifulSoup import BeautifulSoup"

THATS IT.

Hope you get it this time :))

Sorry for confusion and thanks for patience.

CaTzil commented 10 years ago

I got you in the first time, but i prefer to use the latest BS. i checked the last fix, and the addon works fine with it. (got to reinstall the addon) Does it not works for you now?

struart commented 10 years ago

Let me check it again :)

struart commented 10 years ago

Script works with your latest bs4 if there is no subtitles at website. When subtitles are avaible it crash when listing them.

ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS! Error Type: <type 'exceptions.IndexError'> Error Contents: list index out of range Traceback (most recent call last): File "C:\Users\Admin\AppData\Roaming\XBMC\addons\service.subtitles.napisy24pl\service.py", line 348, in Search(item) File "C:\Users\Admin\AppData\Roaming\XBMC\addons\service.subtitles.napisy24pl\service.py", line 212, in Search getallsubs(content, item, subtitles_list) File "C:\Users\Admin\AppData\Roaming\XBMC\addons\service.subtitles.napisy24pl\service.py", line 151, in getallsubs rating_dot = rating[0].replace(",", ".") IndexError: list index out of range -->End of Python script error report<--

CaTzil commented 10 years ago

ham, its not related to BS. Most of the code is ported from FRODO version, and this crush accrues because the movie that you tried to search has not rating in the website (the previous code didn't handle that situation :) what is the movie that you searched for?

struart commented 10 years ago

Game of thrones s04e05 and its working if i go back to bs3 then it list subs and download them fine.

CaTzil commented 10 years ago

OK, you convinced me :] i will change to yours solution

struart commented 10 years ago

Dont forget to fix: soup = bs4.BeautifulSoup(content) to soup = BeautifulSoup(content) :D Thanks.

CaTzil commented 10 years ago

Thank you :]

can you check it now?

struart commented 10 years ago

moment :dancer:

struart commented 10 years ago

OK now it's working good.

CaTzil commented 10 years ago

Excellent, thank you for your attention. I will push it to the XBMC repo.