Add Mimics

[Caaz]

Closes #187 Closes #183

[Caaz]

@CodiumAI-Agent /review

Curious what this will do

[CodiumAI-Agent]

PR Analysis

• 🎯 Main theme: Adding new features and refactoring existing code in a game project

• 📝 PR summary: This PR introduces a new feature, the 'Mimic Matter' ability, to the game. It also includes refactoring of some existing code, renaming of classes, and addition of new classes and methods. The new feature allows game characters to mimic the properties of other objects.

• 📌 Type of PR: Enhancement

• 🧪 Relevant tests added: No

• ⏱️ Estimated effort to review [1-5]: 4 The PR is quite large and involves both the addition of new features and refactoring of existing code. It requires a good understanding of the game's codebase to review effectively.

• 🔒 Security concerns: No security concerns found

  PR Feedback

• 💡 General suggestions: The PR is well-structured and the new feature seems to be implemented correctly. However, it would be beneficial to add some tests to ensure the new feature works as expected and does not introduce any regressions. Additionally, some of the code could be further refactored for better readability and maintainability.

• 🤖 Code feedback:

  • relevant file: Source/MimickedMatter.cs suggestion: Consider adding error handling for the case where the pawn cannot be added to the mimicked thing. Currently, the pawn is destroyed if it cannot be added, but it might be better to throw an exception or at least log an error message. [important] relevant line: '+ if (!mimickedMatter.innerContainer.TryAdd(pawn))'

  • relevant file: Source/AbilityComp/MimicMatter.cs suggestion: Consider refactoring the Apply method to make it more readable. It currently does a lot of things and could be split into smaller, more manageable methods. [medium] relevant line: '+ public override void Apply(LocalTargetInfo target, LocalTargetInfo dest)'

  • relevant file: Source/JobGiver/CastAbilityOnJobTarget.cs suggestion: The class name 'CastAbilityOnJobTarget' is a bit ambiguous. Consider renaming it to something more descriptive, like 'CastAbilityOnTargetJobGiver'. [medium] relevant line: '+ public class CastAbilityOnJobTarget : JobGiver_AICastAbility'

  • relevant file: Source/MimickedMatter.cs suggestion: The Tick method could be refactored for better readability. Consider splitting the if condition into multiple lines or extracting it into a separate method. [medium] relevant line: '+ public override void Tick()'

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands: /review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option. /describe: Modify the PR title and description based on the contents of the PR. /improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback. /ask \<QUESTION>: Pose a question about the PR. /update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value For example: /review --pr_reviewer.extra_instructions="focus on the file: ..." To list the possible configuration parameters, use the /config command.