Trying to pull invalid dependencies fails silently.

CabbageAdi / DSharpPlus.SlashCommands

An extension for DSharpPlus to make slash commands easier

https://discord.gg/2ZhXXVJYhU

MIT License

44 stars 11 forks source link

Trying to pull invalid dependencies fails silently. #16

Closed VelvetToroyashi closed 3 years ago

VelvetToroyashi commented 3 years ago

When attempting to pull an invalid dependency, that is, a dependency that does not exist in the service collection, instead of throwing an exception at runtime, the command gets registered, but its implementation does not get constructed, and thus attempting to invoke it will always fail.

CabbageAdi commented 3 years ago

Looks like dependency injection needs a rework

CabbageAdi commented 3 years ago

Would this count as fixed after the introduction of property injection?