Use system menu button instead of button

[oleastre]

I was a little bit surprised to see the player button in the middle of the top bar, and not next to the other status icons. I do not know if this is desired behavior, but if you want to change it, here is a simple patch that replaces the use of a simple button with a system menu button (which displays as all other status buttons).

diff --git a/mediasplayers@ycdref/extension.js b/mediasplayers@ycdref/extension.js
index 3c268eb..b42f3e3 100644
--- a/mediasplayers@ycdref/extension.js
+++ b/mediasplayers@ycdref/extension.js
@@ -173,23 +173,11 @@ function Indicator() {
 }

 Indicator.prototype = {
-    __proto__: PanelMenu.Button.prototype,
+    __proto__: PanelMenu.SystemStatusButton.prototype,

     _init: function() {

-        this._pIcon = new St.Icon({
-            icon_type: St.IconType.SYMBOLIC,
-            icon_size: Main.panel.button.get_child().height,
-            icon_name: 'audio-x-generic'
-        });
-
-        PanelMenu.Button.prototype._init.call(this,0);
-
-        let tBox = new St.BoxLayout();        
-        tBox.add_actor(this._pIcon);
-        this.actor.set_child(tBox);
-        Main.panel._centerBox.add(this.actor, { y_fill: true });
-        Main.panel._menus.addMenu(this.menu);
+        PanelMenu.SystemStatusButton.prototype._init.call(this,'audio-x-generic');

         this._mediaServer = new MediaServer2Player();
         this._prop = new Prop();

[Caccc]

The project is young, dont worry lot of settings ll be come.

Of course, you can participate.

---

De: oleastre reply@reply.github.com : d_dref@yahoo.fr Envoy le : Mercredi 8 Juin 2011 22h08 Objet: [Gnome-shell-extension-Mediasplayers] Use system menu button instead of button (#2)

I was a little bit surprised to see the player button in the middle of the top bar, and not next to the other status icons. I do not know if this is desired behavior, but if you want to change it, here is a simple patch that replaces the use of a simple button with a system menu button (which displays as all other status buttons).

diff --git a/mediasplayers@ycdref/extension.js b/mediasplayers@ycdref/extension.js
index 3c268eb..b42f3e3 100644
--- a/mediasplayers@ycdref/extension.js
+++ b/mediasplayers@ycdref/extension.js
@@ -173,23 +173,11 @@ function Indicator() {
}

Indicator.prototype = {
-  __proto__: PanelMenu.Button.prototype,
+  __proto__: PanelMenu.SystemStatusButton.prototype,

  _init: function() {

-    this._pIcon = new St.Icon({
-      icon_type: St.IconType.SYMBOLIC,
-      icon_size: Main.panel.button.get_child().height,
-      icon_name: 'audio-x-generic'
-    });
-
-    PanelMenu.Button.prototype._init.call(this,0);
-
-    let tBox = new St.BoxLayout();    
-    tBox.add_actor(this._pIcon);
-    this.actor.set_child(tBox);
-    Main.panel._centerBox.add(this.actor, { y_fill: true });
-    Main.panel._menus.addMenu(this.menu);
+    PanelMenu.SystemStatusButton.prototype._init.call(this,'audio-x-generic');

    this._mediaServer = new MediaServer2Player();
    this._prop = new Prop();

Reply to this email directly or view it on GitHub: https://github.com/Caccc/Gnome-shell-extension-Mediasplayers/issues/2

[oschmid]

How about integrating Mediasplayer with the gnome-shell volume indicator in the status menu (a la ubuntu app-indicator)?