search

CachyOS / CachyOS-Settings

Settings used for CachyOS
GNU General Public License v3.0
91 stars 22 forks source link

tcp patches #37

Closed Rasenkai closed 10 months ago

ventureoo commented 11 months ago

We had previously experienced some regressions with sysctl parameters for the network, so we gave up on them (https://github.com/CachyOS/CachyOS-Settings/commit/bf2eaf259f5a4c1ea67412d5980828097d0b2a67). But this set doesn't seem to be that large, so we can test this and then decide which parameters are okay. I think @aarrayy is more compotent on the question, which is why I listed him as a reviewer.

aarrayy commented 11 months ago

Should be fine but afaik TCP timestamping is needed for some of the BBRv3 functionality, if you take a look into their source code, they're some references about timestamps and RTT calculations and if i'm not wrong net.ipv4.tcp_timestamps = 0 could make it worse?, besides this. The other three are fine and could be added

Rasenkai commented 11 months ago

Should be fine but afaik TCP timestamping is needed for some of the BBRv3 functionality, if you take a look into their source code, they're some references about timestamps and RTT calculations and if i'm not wrong net.ipv4.tcp_timestamps = 0 could make it worse?, besides this. The other three are fine and could be added

Is it the same case with BBRv2? As I'm using these with BBRv2 on android and I do not see any regressions or issues.

ptr1337 commented 10 months ago

Please sign your commits @Rasenkai

Rasenkai commented 10 months ago

Please sign your commits @Rasenkai

done.