CachyOS / cachyos-calamares

CachyOS Calamares
GNU General Public License v3.0
9 stars 7 forks source link

plymouth: Add plymouth support and use CachyOS theme #18

Closed ptr1337 closed 7 months ago

ptr1337 commented 7 months ago

Adds plymouth support as default, this will add to the mkinitcpio.conf to the hooks array the "plymouth" hook.

Also, we need to set "splash" to the kernel cmdline. Tested with systemd-boot.

systemd-boot-manager also needs to set "splash" to the kernel cmdline.

ventureoo commented 7 months ago

Also, we need to set "splash" to the kernel cmdline. Tested with systemd-boot.

Please note that specifying splash without the plymouth hook in mkinitcpio causes the system to be unable to boot. So we should make sure that this kernel parameter is added only when plymouth is installed.

ptr1337 commented 7 months ago

Also, we need to set "splash" to the kernel cmdline. Tested with systemd-boot.

Please note that specifying splash without the plymouth hook in mkinitcpio causes the system to be unable to boot. So we should make sure that this kernel parameter is added only when plymouth is installed.

Existing users should not have overwritten the config from systemd-boot-manager.

ventureoo commented 7 months ago

Also, we need to set "splash" to the kernel cmdline. Tested with systemd-boot.

Please note that specifying splash without the plymouth hook in mkinitcpio causes the system to be unable to boot. So we should make sure that this kernel parameter is added only when plymouth is installed.

Existing users should not have overwritten the config from systemd-boot-manager.

If user has not modified /etc/sdboot-manage.conf in any way before (which can be possible), even if we use backup=(etc/sdboot-manage.conf) in our PKGBUILD, pacman will still overwrite it (see man 8 pacman) and we may run into more boot issues reported by users.

ptr1337 commented 7 months ago

Also, we need to set "splash" to the kernel cmdline. Tested with systemd-boot.

Please note that specifying splash without the plymouth hook in mkinitcpio causes the system to be unable to boot. So we should make sure that this kernel parameter is added only when plymouth is installed.

Existing users should not have overwritten the config from systemd-boot-manager.

If user has not modified /etc/sdboot-manage.conf in any way before (which can be possible), even if we use backup=(etc/sdboot-manage.conf) in our PKGBUILD, pacman will still overwrite it (see man 8 pacman) and we may run into more boot issues reported by users.

Doesnt seem to be the case, ive tested it