CachyOS / chwd

Hardware Detection and Configuration for CachyOS
https://cachyos.org
GNU General Public License v3.0
7 stars 7 forks source link

profiles/graphic_drivers: Make mkinitcpio non-fail if nvidia modules is not found #128

Closed ventureoo closed 2 months ago

ventureoo commented 2 months ago

This usually happens the first time you run mkinitcpio and goes away with subsequent ones.

ptr1337 commented 2 months ago

I think having a "failing" mkinitcpio is quite good, because this makes the user more clear, when they installed a different kernel, but missing to install the nvidia modules.

ventureoo commented 2 months ago

I think having a "failing" mkinitcpio is quite good, because this makes the user more clear, when they installed a different kernel, but missing to install the nvidia modules.

The issue is that if you do nvidia-dkms installation for the first time (which chwd can do), these errors will still be present, which can create a misunderstanding that something is going wrong when reading the chwd logs.

ventureoo commented 2 months ago

Well it looks like having errors is more useful than suppressing them, so closing.