search

Cacti / cacti

Cacti ™
http://www.cacti.net
GNU General Public License v2.0
1.65k stars 404 forks source link

jQuery UI - Update to 1.12.1 #1227

Closed netniV closed 6 years ago

netniV commented 6 years ago

jQuery UI needs to be updated at some point to the 1.12.1 version as per https://github.com/Cacti/cacti/issues/1195#issuecomment-358114935. However, this has CSS and JS implications as themes may need to be rebuilt etc.

netniV commented 6 years ago

It was noted that most themes seem to be based off Smoothness, and that we would need to rework from Base. However, I noticed that Smoothness was still available as a theme to download even under 1.12.1. So, as a starting point, I dropped in the latest js to /include/js/jquery-ui.js, and the jquery-ui.theme.css to /include/themes/modern/jquery-ui.css I ended up with the following layout differences:

image

cigamit commented 6 years ago

Which is which?

netniV commented 6 years ago

Left is new, right is current.

cigamit commented 6 years ago

Yea, that might be the jQuery time picker plugin. You better see if there is an update for it.

netniV commented 6 years ago

The drop downs have done the same time so I think the next thing is to see what's in main.css that's overriding the jquery-ui.css

cigamit commented 6 years ago

Latest Timepicker was just merged into develop. See if that fixes things.

pautiina commented 6 years ago

74

cigamit commented 6 years ago

David gave us a free timepicker, but did not update the CSS file. Not entirely sure that is is, but I'm guessing maybe. I've asked him to do a fresh pull and include the CSS.

cigamit commented 6 years ago

Alex, all fixed up. Keep them coming.

paulgevers commented 6 years ago

Please check the work done in issue #186.

I am already doing this in Debian since 1.1.3.

cigamit commented 6 years ago

Closing since this is a duplicate of #186.