search

Cacti / cacti

Cacti ™
http://www.cacti.net
GNU General Public License v2.0
1.65k stars 406 forks source link

Remote Data Collector install/upgrade should fail if Remote Data Collector is a newer release #3214

Open TheWitness opened 4 years ago

TheWitness commented 4 years ago

Describe the bug If you attempt to upgrade or install a remote data collector, and that remote data collector is a more recent version of cacti, it should be blocked.

To Reproduce Steps to reproduce the behavior:

  1. Install main Cacti collector at version 1.2.8
  2. Attempt to install a remote data collector at version 1.2.9
  3. Bad things start to happen including installer failures

Expected behavior Newer remote data collector installs should be blocked.

cigamit commented 4 years ago

Yea, I see how that could be bad.

netniV commented 4 years ago

The problem we have here is whether the main connection is online or not. IF the connection is not online, do we block installation completely?

eg.

<?php if ($config['connection'] != 'online') {?>
fatal('Cannot install remote poller, main connection is offline');
<?php } ?>
cigamit commented 4 years ago

This makes sense. Right now anyway, we have to be able to connect to the main data collector to complete the install. In 1.3, it would be fine if we allowed remote data collectors to self register. That way, you could spin up docker images and have the auto-register. For this release anyway, let's block.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

netniV commented 4 years ago

This is still work in progress

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.